Skip to content

coast: DCW painting inside/outside issue#9015

Merged
joa-quim merged 6 commits into
masterfrom
fix-5151
May 18, 2026
Merged

coast: DCW painting inside/outside issue#9015
joa-quim merged 6 commits into
masterfrom
fix-5151

Conversation

@joa-quim
Copy link
Copy Markdown
Member

Fix #5151

Assisted-by: Claude Opus 4.7

Fix #5151

Assisted-by: Claude Opus 4.7
@joa-quim
Copy link
Copy Markdown
Member Author

@Esteban82 please test if this is what you were expecting. The example command does not run (has pairs of **)

@Esteban82
Copy link
Copy Markdown
Member

It doesn't work. It is even worse. Now Chile is paint as part of the ocean.

DCW_BUG

@Esteban82
Copy link
Copy Markdown
Member

I think Claude change how -S works. Maybe we should try with a simpler example:

gmt begin DCW_BUG png
	gmt coast  -Rd -JG-65/-30/6.1/5 -EAR+grosybrown2+p -Da -W1/ -B0
	gmt coast  -Rd -JG-65/-30/6.2/5 -EAR+grosybrown2+p -Da -W1/ -B0 -Xw
gmt end
DCW_BUG2

@seisman
Copy link
Copy Markdown
Member

seisman commented May 14, 2026

Please remember to check the CI runs as any small changes may work for one test but break others.

@joa-quim
Copy link
Copy Markdown
Member Author

Something strange is in the air. This is what I get with this branch.

DCW_BUG

@joa-quim
Copy link
Copy Markdown
Member Author

And your example produces this.

DCW_BUG

@Esteban82
Copy link
Copy Markdown
Member

Yes, there is something weird. I got my result with this version (6.7.0_2265fd9_2026.03.24) on linux.

@joa-quim
Copy link
Copy Markdown
Member Author

Tested in another computer and this fix is working fine.

@joa-quim
Copy link
Copy Markdown
Member Author

And can you confirm this one? (would like to commit this shortly)

@Esteban82
Copy link
Copy Markdown
Member

Now it works on my laptop! I got this figure.

And your example produces this.

DCW_BUG

@Esteban82
Copy link
Copy Markdown
Member

On my computer with Linux I got the wrong figure!! It is the same GMT version.

@joa-quim
Copy link
Copy Markdown
Member Author

The figure is not visible. But you are saying that Win and Linux are producing different figures?

@Esteban82
Copy link
Copy Markdown
Member

The figure is not visible. But you are saying that Win and Linux are producing different figures?

Yes, exactly that.

@joa-quim joa-quim requested a review from a team May 18, 2026 14:11
Copy link
Copy Markdown
Member

@Esteban82 Esteban82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works on Linux.

@Esteban82 Esteban82 added add-changelog Add PR to the changelog AI-assisted All (or most) of the code was written by Artificial Intelligence. labels May 18, 2026
@joa-quim joa-quim merged commit 447ce0e into master May 18, 2026
10 of 19 checks passed
@joa-quim joa-quim deleted the fix-5151 branch May 18, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add-changelog Add PR to the changelog AI-assisted All (or most) of the code was written by Artificial Intelligence.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug with DCW painting inside/outside

3 participants